*: consistently use versioned URLs to docs#18986
Merged
benesch merged 1 commit intocockroachdb:masterfrom Oct 4, 2017
Merged
Conversation
Member
|
This change is |
Contributor
|
Reviewed 8 of 8 files at r1. Comments from Reviewable |
Contributor
|
LGTM |
Previously, some links to the docs website hardcoded the "stable" version alias. Since the "stable" content is updated with every release, the link points to increasingly irrelevant content for old binaries. Instead, derive a docs "permalink" from the binary's version. (This logic previously existed in sql/parser; this commit simply applies that logic to docs URLs in other packages.) Fix cockroachdb#18984.
Contributor
Author
|
TFTRs! |
This was referenced Oct 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, some links to the docs website hardcoded the "stable"
version alias. Since the "stable" content is updated with every release,
the link points to increasingly irrelevant content for old binaries.
Instead, derive a docs "permalink" from the binary's version. (This
logic previously existed in sql/parser; this commit simply applies that
logic to docs URLs in other packages.)
Fix #18984.
@knz can you review? (The reviewers field is broken.)