This change is 

Thanks for the contribution! A few comments enclosed.

The difference between the true and false argument is pretty minor I think and I only discovered it by looking at the Postgres source code. It controls whether the output is formatted using disambiguating parentheses.

For example:

tpcc=# create view a as select 1+2 from customer;
CREATE VIEW
tpcc=# select pg_get_viewdef('a'::regclass, false);
  pg_get_viewdef
-------------------
  SELECT (1 + 2)  +
    FROM customer;
(1 row)

tpcc=# select pg_get_viewdef('a'::regclass, true);
  pg_get_viewdef
-------------------
  SELECT 1 + 2    +
    FROM customer;
(1 row)

I'm fine with us ignoring this difference entirely.

Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

pkg/sql/logictest/testdata/logic_test/builtin_function, line 1605 at r1 (raw file):

query T
SELECT pg_catalog.pg_get_viewdef((SELECT oid FROM pg_class WHERE relname='pg_viewdef_view'))

There's a shortcut for this, so you don't have to do this subselect: 'pg_viewdef_view'::regclass'.

pkg/sql/parser/pg_builtins.go, line 231 at r1 (raw file):

				}
				if len(r) == 0 {
					return nil, pgerror.NewErrorf(pgerror.CodeInvalidParameterValueError, "unknown view (OID=%s)", args[0])

This should return NULL like it does in Postgres, not an error.

pkg/sql/parser/pg_builtins.go, line 237 at r1 (raw file):

			Info: notUsableInfo,
		},
		Builtin{

It's fine that we have no special behavior in this overload, but it seems unnecessary to me to repeat the code in both overloads. Could you DRY this definition?

Comments from Reviewable

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

Comments from Reviewable

sounds good!

Comments from Reviewable

pkg/sql/logictest/testdata/logic_test/builtin_function, line 1605 at r1 (raw file):

I will update with this, thanks for the pointer.

Comments from Reviewable

pkg/sql/parser/pg_builtins.go, line 231 at r1 (raw file):

Agreed.

Comments from Reviewable

pkg/sql/parser/pg_builtins.go, line 237 at r1 (raw file):

Sounds good, I will refactor it.

Comments from Reviewable

pkg/sql/logictest/testdata/logic_test/builtin_function, line 1605 at r1 (raw file):

Done.

Comments from Reviewable

pkg/sql/parser/pg_builtins.go, line 231 at r1 (raw file):

Done.

Comments from Reviewable

pkg/sql/parser/pg_builtins.go, line 237 at r1 (raw file):

Done.

Comments from Reviewable

thanks again!

Reviewed 2 of 2 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable