sql: add miscellaneous Postgres compatibility#18530
Merged
jordanlewis merged 5 commits intocockroachdb:masterfrom Sep 17, 2017
Merged
sql: add miscellaneous Postgres compatibility#18530jordanlewis merged 5 commits intocockroachdb:masterfrom
jordanlewis merged 5 commits intocockroachdb:masterfrom
Conversation
Member
jordanlewis
commented
Sep 17, 2017
- support "char" type as alias to char
- add and link pg_tablespace table
- add pg_encoding_to_char builtin
- add missing relpersistence column to pg_class
- fix pg_namespace column name: aclitem should be nspacl
Column was named aclitem, this is incorrect. It's supposed to be named nspacl.
This column describes whether a table is temporary, permanent, or unlogged. We only support permanent.
This builtin converts database encoding ids to human-readable names. We only support UTF8 as an encoding.
Member
|
This change is |
955e2ba to
0bb8a3f
Compare
Contributor
|
Reviewed 2 of 2 files at r1, 2 of 2 files at r2, 3 of 3 files at r3, 4 of 4 files at r4, 3 of 3 files at r5. Comments from Reviewable |
This pg_catalog table records the tablespace of databases and tables, a Postgres concept that we don't support. As such, we hardcode all databases to a single default tablespace with the same name as the one in Postgres.
Postgres has a type called "char" (with the quotes) that is a single-character string. It's used for system tables as a lightweight enum type. Some ORMs cast input data to "char" to compare against these tables, so we need to support it in the parser.
0bb8a3f to
86cf99f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.