*: use proto.Unmarshal#18455
Merged
petermattis merged 1 commit intocockroachdb:masterfrom Sep 12, 2017
Merged
Conversation
Member
|
This change is |
Member
|
LGTM. Time to name all my variables |
1c68abb to
7c8ea34
Compare
nvb
approved these changes
Sep 12, 2017
`<proto>.Unmarshal` has surprising behavior in that it merges with the existing data in the structure instead of over-writing it. Add `TestProtoUnmarshal` linter. Fixes cockroachdb#18407
7c8ea34 to
499bba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<proto>.Unmarshalhas surprising behavior in that it merges with theexisting data in the structure instead of over-writing it.
Add
TestProtoUnmarshallinter.Fixes #18407