sql: fix the double render optimization for views#17305
Merged
knz merged 1 commit intocockroachdb:masterfrom Jul 30, 2017
Merged
sql: fix the double render optimization for views#17305knz merged 1 commit intocockroachdb:masterfrom
knz merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Member
|
LGTM. The explanation makes sense to me but I'm not very familiar with the implementation around views, maybe @jordanlewis should take a look too Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful. pkg/sql/expand_plan.go, line 341 at r2 (raw file):
put it pkg/sql/expand_plan.go, line 346 at r2 (raw file):
as a source Comments from Reviewable |
ac02d7f to
f540c9a
Compare
Contributor
Author
This reverts commit 74c7b0f. The "optimization" in that commit was simply invalid. The field `sourceRender.source.info.viewDesc` must not be overwritten if that was the non-nil field and `r.source.info.viewDesc` was nil. Will submit the correct optimization in a subsequent commit.
f540c9a to
d57e9f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous commit to do that was rather wrong. I have re-written the patch and added an extensive comment to explain what was going on, and a test that checks the descriptor dependencies are properly set up.