Merged
Conversation
Member
|
This change is |
Pending cockroachdb#16977, this gives a crude way of landing changes that will need a proper migration. The "problem" with this change is that this means that tests won't be run with the new code completely active. We can change that, but it would approximately double time spent in CI, so that I'm not convinced it's worth it at this point. Instead, the "new mode" should be tested thoroughly when it can properly be migrated into.
Member
Author
|
From #16993:
-- @petermattis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending #16977, this gives a crude way of landing changes that
will need a proper migration.
The "problem" with this change is that this means that tests won't be run with
the new code completely active. We can change that, but it would approximately
double time spent in CI, so that I'm not convinced it's worth it at this point.
Instead, the "new mode" should be tested thoroughly when it can properly be
migrated into.