mmaintegration: add TestMakeStoreLoadMsg#164882
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom Mar 6, 2026
Merged
mmaintegration: add TestMakeStoreLoadMsg#164882trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Contributor
|
😎 Merged successfully - details. |
Member
|
This change is |
tbg
approved these changes
Mar 5, 2026
Member
tbg
left a comment
There was a problem hiding this comment.
@tbg reviewed 14 files and all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on wenyihu6).
tbg
approved these changes
Mar 5, 2026
Member
tbg
left a comment
There was a problem hiding this comment.
@tbg made 1 comment.
Reviewable status:
Contributor
Author
|
Rebased. TFTR! /trunk merge |
725f293 to
0f5af46
Compare
Contributor
Author
|
/trunk merge |
The capped multiplier model (`computeCPUCapacityWithCap`) subtracts background CPU when deriving per-store capacity. This mistakenly broke the invariant that node-level utilization can be recovered by summing store-level values: sum(store loads) / sum(store capacities) = NodeCPURateUsage / NodeCPURateCapacity `MakeStoreLoadMsg` addresses this by populating `StoreLoadMsg.NodeCPULoad` and `StoreLoadMsg.NodeCPUCapacity` from the physical node values in `StoreDescriptor.NodeCapacity`, so that node-level overload detection uses the correct utilization. This commit adds `TestMakeStoreLoadMsg`, a regression test that exercises the full path from `StoreDescriptor` through `MakeStoreLoadMsg` and `ProcessStoreLoadMsg` into `LoadSummaryForAllStores`. Release note: None
Contributor
Author
|
/trunk merge |
1 similar comment
Contributor
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic: CRDB-55052
Release note: none
The capped multiplier model (
computeCPUCapacityWithCap) subtractsbackground CPU when deriving per-store capacity. This mistakenly
broke the invariant that node-level utilization can be recovered by
summing store-level values:
sum(store loads) / sum(store capacities) = NodeCPURateUsage / NodeCPURateCapacity
MakeStoreLoadMsgaddresses this by populatingStoreLoadMsg.NodeCPULoadandStoreLoadMsg.NodeCPUCapacityfrom thephysical node values in
StoreDescriptor.NodeCapacity, so thatnode-level overload detection uses the correct utilization.
This commit adds
TestMakeStoreLoadMsg, a regression test thatexercises the full path from
StoreDescriptorthroughMakeStoreLoadMsgandProcessStoreLoadMsgintoLoadSummaryForAllStores.