sql/types: remove VisibleType field and NAME downgrade logic#164412
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom Feb 27, 2026
Merged
sql/types: remove VisibleType field and NAME downgrade logic#164412trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Contributor
|
😎 Merged successfully - details. |
|
It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
3272317 to
7e49444
Compare
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
7e49444 to
32944c0
Compare
The `VisibleType` field in the `InternalType` protobuf was a pre-19.1 mechanism for encoding type aliases (INT4, FLOAT4, VARCHAR, etc.). It was superseded by the `Oid` field in 19.2 but kept for backward compatibility during mixed-version clusters. Now that `MinSupported` is v25.4, no mixed-version cluster will include a node older than v25.4, which already populates the `Oid` field. This commit removes: - The `VisibleType` field from the proto (replaced with `reserved 6`) - All `visible*` constants and VisibleType assignments in canonical types, constructors, and the SQL parser - The VisibleType-based OID inference in `upgradeType()`, keeping only Width-based inference for old backup compatibility - The `downgradeType()` function and NAME serialization special-casing in Marshal/MarshalTo/MarshalToSizedBuffer/Size/MarshalJSONPB - The VisibleType reconstruction logic in UnmarshalJSONPB - The `duringUpgradeTo25_4` forced descriptor rewrite in the first upgrade migration - Related test infrastructure (VisibleType comparison filters, old format test cases) Resolves: cockroachdb#152629 Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
32944c0 to
a2e89c7
Compare
spilchen
approved these changes
Feb 27, 2026
Contributor
spilchen
left a comment
There was a problem hiding this comment.
@spilchen reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on mw5h).
Collaborator
Author
|
/trunk merge tftr! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
VisibleTypefield in theInternalTypeprotobuf was a pre-19.1 mechanism for encoding type aliases (INT4, FLOAT4, VARCHAR, etc.). It was superseded by theOidfield in 19.2 but kept for backward compatibility during mixed-version clusters.Now that
MinSupportedis v25.4, no mixed-version cluster will include a node older than v25.4, which already populates theOidfield. This commit removes:VisibleTypefield from the proto (replaced withreserved 6)visible*constants and VisibleType assignments in canonical types, constructors, and the SQL parserupgradeType(), keeping only Width-based inference for old backup compatibilitydowngradeType()function and NAME serialization special-casing in Marshal/MarshalTo/MarshalToSizedBuffer/Size/MarshalJSONPBduringUpgradeTo25_4forced descriptor rewrite in the first upgrade migrationResolves: #152629
Release note: None