sql: resolve test tenant randomization for observability tests#161874
sql: resolve test tenant randomization for observability tests#161874craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
There was a problem hiding this comment.
Thanks!
@yuzefovich reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dhartunian and @kyle-a-wong).
-- commits line 11 at r1:
Just double-checking that you stressed this test for a bit - it must have failed at least once a few months ago which is what caused me to disable tenant randomization.
dhartunian
left a comment
There was a problem hiding this comment.
@dhartunian made 1 comment.
Reviewable status:
Previously, yuzefovich (Yahor Yuzefovich) wrote…
Just double-checking that you stressed this test for a bit - it must have failed at least once a few months which is what caused me to disable tenant randomization.
Haven't. Will do.
yuzefovich
left a comment
There was a problem hiding this comment.
@yuzefovich made 1 comment.
Reviewable status:
Previously, dhartunian (David Hartunian) wrote…
Haven't. Will do.
Looks like it's failing on stress CI already 😬
aa398dc to
d4210a3
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
d4210a3 to
83d4744
Compare
This addresses the three tests that had test tenant randomization disabled under issue cockroachdb#156145. TestShowRangesWithDetails now runs with tenant randomization enabled. The underlying tenant_span_stats() function is designed for tenant use and the test passes with an external process virtual cluster. TestShowRangesUnavailableReplicas remains disabled for tenants because it requires controlling server lifecycle (stopping servers to create unavailable ranges) and uses manual replication mode - both are KV-layer infrastructure operations that tenants cannot perform. TestTxnContentionEventsTableWithRangeDescriptor remains disabled for tenants because it tests contention event handling for range descriptor keys, which are KV-internal keys that secondary tenants never interact with. Note that TestTxnContentionEventsTableMultiTenant already tests contention events with tenants enabled and passes. For the two tests that must remain system-tenant-only, the annotation was changed from TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet to TestIsSpecificToStorageLayerAndNeedsASystemTenant to clearly indicate these are intentional exclusions, not bugs. Closes: cockroachdb#156145 Release note: None
83d4744 to
eb469d4
Compare
|
bors r=yuzefovich |
|
bors r+ |
This addresses the three tests that had test tenant randomization disabled under issue #156145.
TestShowRangesWithDetails now runs with tenant randomization enabled. The underlying tenant_span_stats() function is designed for tenant use and the test passes with an external process virtual cluster.
TestShowRangesUnavailableReplicas remains disabled for tenants because it requires controlling server lifecycle (stopping servers to create unavailable ranges) and uses manual replication mode - both are KV-layer infrastructure operations that tenants cannot perform.
TestTxnContentionEventsTableWithRangeDescriptor remains disabled for tenants because it tests contention event handling for range descriptor keys, which are KV-internal keys that secondary tenants never interact with. Note that TestTxnContentionEventsTableMultiTenant already tests contention events with tenants enabled and passes.
For the two tests that must remain system-tenant-only, the annotation was changed from TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet to TestIsSpecificToStorageLayerAndNeedsASystemTenant to clearly indicate these are intentional exclusions, not bugs.
Closes: #156145
Release note: None