sql: fix TestNumRangesInSpanContainedBy for multitenant mode#160593
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 7, 2026
Merged
sql: fix TestNumRangesInSpanContainedBy for multitenant mode#160593craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Previously, the test used `s.ScratchRange()` which returns a key in the system keyspace, outside the tenant's accessible keyspace. When running in multitenant mode, the RangeIterator would fail with an "Unauthenticated" error because the tenant cannot access keys outside its keyspace. This commit fixes the test by: 1. Using a tenant-prefixed scratch key via `Codec().TenantPrefix()` + `keys.ScratchRangeMin`, which ensures the key is within the tenant's keyspace. 2. Adding a scan after splitting ranges to populate the tenant's range cache with the new range descriptors. Resolves: cockroachdb#107376 Release note: None
507bb9c to
69ca7e4
Compare
fqazi
approved these changes
Jan 7, 2026
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
@fqazi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss).
Collaborator
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the test used
s.ScratchRange()which returns a key in the system keyspace, outside the tenant's accessible keyspace. When running in multitenant mode, the RangeIterator would fail with an "Unauthenticated" error because the tenant cannot access keys outside its keyspace.This commit fixes the test by:
Codec().TenantPrefix()+keys.ScratchRangeMin, which ensures the key is within the tenant's keyspace.Resolves: #107376
Release note: None