sql: make TestDropFunction work with test tenant#160520
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 6, 2026
Merged
sql: make TestDropFunction work with test tenant#160520craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously, TestDropFunction hard-coded descriptor IDs (e.g., 109 for the function, 104-108 for tables/sequences/views/types) which only work when run against the system tenant. When running against a secondary tenant, these IDs are different because tenants have their own descriptor ID space. This commit fixes the test by querying object IDs programmatically: - Table, sequence, and view IDs via sqlutils.QueryTableID - Function ID via crdb_internal.create_function_statements - Type IDs via regtype casts with catid.UserDefinedOIDToID conversion The test now works correctly with both system and secondary tenants. Resolves: cockroachdb#107322 Epic: None Release note: None
Member
|
This change is |
Collaborator
Author
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, TestDropFunction hard-coded descriptor IDs (e.g., 109 for the function, 104-108 for tables/sequences/views/types) which only work when run against the system tenant. When running against a secondary tenant, these IDs are different because tenants have their own descriptor ID space.
This commit fixes the test by querying object IDs programmatically:
The test now works correctly with both system and secondary tenants.
Resolves: #107322
Epic: None
Release note: None