pgwire: fix TestPGTest/large_input for shared process tenants#160502
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 6, 2026
Merged
pgwire: fix TestPGTest/large_input for shared process tenants#160502craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Previously, the TestPGTest/large_input test failed when running with a shared process virtual cluster because the cluster setting `sql.conn.max_read_buffer_message_size` was only set on the application tenant. In shared process mode, SQL connections come through the system tenant's pgwire listener, and the PreServeConnHandler uses the system tenant's settings to validate message sizes before routing to the appropriate tenant. This commit fixes the test by also setting the cluster setting on the system tenant, ensuring that the message size limit is enforced correctly in both standalone and shared process modes. Fixes: cockroachdb#112960 Epic: CRDB-48944 Release note: None
yuzefovich
approved these changes
Jan 6, 2026
Member
yuzefovich
left a comment
There was a problem hiding this comment.
Thanks!
@yuzefovich reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball).
Collaborator
Author
|
tftr! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the TestPGTest/large_input test failed when running with a shared process virtual cluster because the cluster setting
sql.conn.max_read_buffer_message_sizewas only set on the application tenant. In shared process mode, SQL connections come through the system tenant's pgwire listener, and the PreServeConnHandler uses the system tenant's settings to validate message sizes before routing to the appropriate tenant.This commit fixes the test by also setting the cluster setting on the system tenant, ensuring that the message size limit is enforced correctly in both standalone and shared process modes.
Fixes: #112960
Epic: CRDB-48944
Release note: None