workload/schemachanger: fix potential error for DETACHED flag in inspect#158875
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 5, 2025
Merged
workload/schemachanger: fix potential error for DETACHED flag in inspect#158875craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
rafiss
approved these changes
Dec 5, 2025
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
thanks! i actually think we need to add both error codes.
- SyntaxError happens if the command is sent to an old binary.
- FeatureNotSupported happens if the command is sent to a new binary, before the version upgrade has been finalized
Previously, this was incorrectly expecting the pgcode FeatureNotSuported, when it should have been SyntaaxError. Fixes: cockroachdb#158837 Release note: None
20794e1 to
8acf269
Compare
Collaborator
Author
Added both. TFTR! |
Collaborator
Author
|
@rafiss TFTR! bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this was incorrectly expecting the pgcode FeatureNotSuported, when it should have been SyntaaxError.
Fixes: #158837
Release note: None