roachtest: fix conditional build for arm64 and fips#157759
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 13, 2025
Merged
roachtest: fix conditional build for arm64 and fips#157759craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
PR cockroachdb#157158 introduced a conditional build for ARM64 and FIPS architectures based on the metamorphic probability flags. The initial implementation used `bc` to compare floating point, but the command is not available on the TeamCity agents. This patch uses `awk` in place of `bc`. Epic: none Release note: None
Member
|
This change is |
Contributor
Author
|
Test TC run with |
herkolategan
approved these changes
Nov 13, 2025
Contributor
Author
|
TFTR! bors r=herkolategan |
srosenberg
approved these changes
Nov 13, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #157158 introduced a conditional build for ARM64 and FIPS architectures based on the metamorphic probability flags.
The initial implementation used
bcto compare floating point, but the command is not available on the TeamCity agents:This patch uses
awkin place ofbc.Epic: none
Release note: None