sql, sqlstats: Refactor Statement Recording#156489
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 18, 2025
Merged
sql, sqlstats: Refactor Statement Recording#156489craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
9f6c985 to
5fc5483
Compare
Contributor
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
Member
🔴 Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/5fc5483/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/5fc5483c5c225541f37e38b42f9e95c3b53789aa/bin/pkg_sql_tests benchdiff/5fc5483/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/5fc5483/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/d669516/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/d6695166a4ec91179d1e48cf31c3d821cac6d955/bin/pkg_sql_tests benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=d669516 --new=5fc5483 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/5fc5483/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/5fc5483c5c225541f37e38b42f9e95c3b53789aa/bin/pkg_sql_tests benchdiff/5fc5483/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/5fc5483/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/d669516/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/d6695166a4ec91179d1e48cf31c3d821cac6d955/bin/pkg_sql_tests benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=d669516 --new=5fc5483 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/5fc5483/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/5fc5483c5c225541f37e38b42f9e95c3b53789aa/bin/pkg_sql_tests benchdiff/5fc5483/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/5fc5483/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/d669516/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/d6695166a4ec91179d1e48cf31c3d821cac6d955/bin/pkg_sql_tests benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=d669516 --new=5fc5483 ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/5fc5483c5c225541f37e38b42f9e95c3b53789aa/19086800702-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/d6695166a4ec91179d1e48cf31c3d821cac6d955/19086800702-1/\* old/built with commit: 5fc5483c5c225541f37e38b42f9e95c3b53789aa |
5fc5483 to
c9404e9
Compare
Member
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/c9404e9/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c9404e96479affb56004b1ddbe86cfb016808583/bin/pkg_sql_tests benchdiff/c9404e9/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c9404e9/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/d669516/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/d6695166a4ec91179d1e48cf31c3d821cac6d955/bin/pkg_sql_tests benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=d669516 --new=c9404e9 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/c9404e9/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c9404e96479affb56004b1ddbe86cfb016808583/bin/pkg_sql_tests benchdiff/c9404e9/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c9404e9/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/d669516/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/d6695166a4ec91179d1e48cf31c3d821cac6d955/bin/pkg_sql_tests benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=d669516 --new=c9404e9 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/c9404e9/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c9404e96479affb56004b1ddbe86cfb016808583/bin/pkg_sql_tests benchdiff/c9404e9/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c9404e9/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/d669516/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/d6695166a4ec91179d1e48cf31c3d821cac6d955/bin/pkg_sql_tests benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=d669516 --new=c9404e9 ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/c9404e96479affb56004b1ddbe86cfb016808583/19110468493-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/d6695166a4ec91179d1e48cf31c3d821cac6d955/19110468493-1/\* old/built with commit: c9404e96479affb56004b1ddbe86cfb016808583 |
c9404e9 to
a26646b
Compare
Member
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/a26646b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/a26646b6033d461cc50a1ecd427166ebdab65bd3/bin/pkg_sql_tests benchdiff/a26646b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/a26646b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/d669516/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/d6695166a4ec91179d1e48cf31c3d821cac6d955/bin/pkg_sql_tests benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=d669516 --new=a26646b ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/a26646b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/a26646b6033d461cc50a1ecd427166ebdab65bd3/bin/pkg_sql_tests benchdiff/a26646b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/a26646b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/d669516/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/d6695166a4ec91179d1e48cf31c3d821cac6d955/bin/pkg_sql_tests benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=d669516 --new=a26646b ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/a26646b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/a26646b6033d461cc50a1ecd427166ebdab65bd3/bin/pkg_sql_tests benchdiff/a26646b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/a26646b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/d669516/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/d6695166a4ec91179d1e48cf31c3d821cac6d955/bin/pkg_sql_tests benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/d669516/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=d669516 --new=a26646b ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/a26646b6033d461cc50a1ecd427166ebdab65bd3/19111374200-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/d6695166a4ec91179d1e48cf31c3d821cac6d955/19111374200-1/\* old/built with commit: a26646b6033d461cc50a1ecd427166ebdab65bd3 |
a26646b to
7a6ea14
Compare
7a6ea14 to
a76e52b
Compare
Member
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/a76e52b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/a76e52bd306cf15439d81dbf73a70b5d97937d92/bin/pkg_sql_tests benchdiff/a76e52b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/a76e52b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/c9eda2b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c9eda2b92a04af26604cffb20f18ece56e0fd62b/bin/pkg_sql_tests benchdiff/c9eda2b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c9eda2b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=c9eda2b --new=a76e52b ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/a76e52b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/a76e52bd306cf15439d81dbf73a70b5d97937d92/bin/pkg_sql_tests benchdiff/a76e52b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/a76e52b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/c9eda2b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c9eda2b92a04af26604cffb20f18ece56e0fd62b/bin/pkg_sql_tests benchdiff/c9eda2b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c9eda2b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=c9eda2b --new=a76e52b ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/a76e52b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/a76e52bd306cf15439d81dbf73a70b5d97937d92/bin/pkg_sql_tests benchdiff/a76e52b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/a76e52b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/c9eda2b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c9eda2b92a04af26604cffb20f18ece56e0fd62b/bin/pkg_sql_tests benchdiff/c9eda2b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c9eda2b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=c9eda2b --new=a76e52b ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/a76e52bd306cf15439d81dbf73a70b5d97937d92/19234667958-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/c9eda2b92a04af26604cffb20f18ece56e0fd62b/19234667958-1/\* old/built with commit: a76e52bd306cf15439d81dbf73a70b5d97937d92 |
a76e52b to
732bd75
Compare
Member
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/732bd75/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/732bd7528286cd3b92114def032982c77570c2ad/bin/pkg_sql_tests benchdiff/732bd75/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/732bd75/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/c9eda2b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c9eda2b92a04af26604cffb20f18ece56e0fd62b/bin/pkg_sql_tests benchdiff/c9eda2b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c9eda2b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=c9eda2b --new=732bd75 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/732bd75/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/732bd7528286cd3b92114def032982c77570c2ad/bin/pkg_sql_tests benchdiff/732bd75/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/732bd75/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/c9eda2b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c9eda2b92a04af26604cffb20f18ece56e0fd62b/bin/pkg_sql_tests benchdiff/c9eda2b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c9eda2b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=c9eda2b --new=732bd75 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/732bd75/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/732bd7528286cd3b92114def032982c77570c2ad/bin/pkg_sql_tests benchdiff/732bd75/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/732bd75/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/c9eda2b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c9eda2b92a04af26604cffb20f18ece56e0fd62b/bin/pkg_sql_tests benchdiff/c9eda2b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c9eda2b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=c9eda2b --new=732bd75 ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/732bd7528286cd3b92114def032982c77570c2ad/19238900399-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/c9eda2b92a04af26604cffb20f18ece56e0fd62b/19238900399-1/\* old/built with commit: 732bd7528286cd3b92114def032982c77570c2ad |
732bd75 to
71dadf3
Compare
Member
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/71dadf3/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/71dadf342dcb9ed701028651789d84a2da52a431/bin/pkg_sql_tests benchdiff/71dadf3/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/71dadf3/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/e9e92b1/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/e9e92b158823fe01fee0c97df029e893f4d9b35d/bin/pkg_sql_tests benchdiff/e9e92b1/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/e9e92b1/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=e9e92b1 --new=71dadf3 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/71dadf3/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/71dadf342dcb9ed701028651789d84a2da52a431/bin/pkg_sql_tests benchdiff/71dadf3/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/71dadf3/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/e9e92b1/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/e9e92b158823fe01fee0c97df029e893f4d9b35d/bin/pkg_sql_tests benchdiff/e9e92b1/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/e9e92b1/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=e9e92b1 --new=71dadf3 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/71dadf3/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/71dadf342dcb9ed701028651789d84a2da52a431/bin/pkg_sql_tests benchdiff/71dadf3/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/71dadf3/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/e9e92b1/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/e9e92b158823fe01fee0c97df029e893f4d9b35d/bin/pkg_sql_tests benchdiff/e9e92b1/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/e9e92b1/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=e9e92b1 --new=71dadf3 ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/71dadf342dcb9ed701028651789d84a2da52a431/19304159637-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/e9e92b158823fe01fee0c97df029e893f4d9b35d/19304159637-1/\* old/built with commit: 71dadf342dcb9ed701028651789d84a2da52a431 |
71dadf3 to
8e701a1
Compare
Member
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/8e701a1/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/8e701a14262b7cc0455a34200464920b1c00b262/bin/pkg_sql_tests benchdiff/8e701a1/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/8e701a1/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/e9e92b1/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/e9e92b158823fe01fee0c97df029e893f4d9b35d/bin/pkg_sql_tests benchdiff/e9e92b1/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/e9e92b1/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=e9e92b1 --new=8e701a1 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/8e701a1/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/8e701a14262b7cc0455a34200464920b1c00b262/bin/pkg_sql_tests benchdiff/8e701a1/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/8e701a1/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/e9e92b1/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/e9e92b158823fe01fee0c97df029e893f4d9b35d/bin/pkg_sql_tests benchdiff/e9e92b1/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/e9e92b1/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=e9e92b1 --new=8e701a1 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/8e701a1/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/8e701a14262b7cc0455a34200464920b1c00b262/bin/pkg_sql_tests benchdiff/8e701a1/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/8e701a1/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/e9e92b1/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/e9e92b158823fe01fee0c97df029e893f4d9b35d/bin/pkg_sql_tests benchdiff/e9e92b1/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/e9e92b1/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=e9e92b1 --new=8e701a1 ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/8e701a14262b7cc0455a34200464920b1c00b262/19307464019-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/e9e92b158823fe01fee0c97df029e893f4d9b35d/19307464019-1/\* old/built with commit: 8e701a14262b7cc0455a34200464920b1c00b262 |
dhartunian
reviewed
Nov 17, 2025
Collaborator
dhartunian
left a comment
There was a problem hiding this comment.
@dhartunian reviewed 31 of 31 files at r1, 1 of 7 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @aa-joshi, @Abhinav1299, @alyshanjahani-crl, and @arjunmahishi)
pkg/sql/sqlstats/sslocal/sslocal_stats_collector.go line 42 at r2 (raw file):
// If no stats have been attempted to be recorded yet for the current statement, // this value will be 0. stmtFingerprintID appstatspb.StmtFingerprintID
huh, guess this is just unused?
pkg/sql/sqlstats/ssprovider.go line 86 at r1 (raw file):
Nodes []int64 KVNodeIDs []int32 StatementType string
why did this type change?
pkg/sql/sqlstats/ssprovider.go line 161 at r2 (raw file):
} func NewRecordedStatementStatsBuilder[L StatementLatencyRecorder](
nit: docstring would be nice. specifically I want to know about the requirements when constructing one of these. Can we skip all the builder pieces? Is there a minimum set?
Also, why is the builder parameterized on L? why can't just the LatencyRecorder method accept a StatementLatencyRecorder?
8e701a1 to
f607041
Compare
Member
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/f607041/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/f607041c5b440ebac46aae6e7a8166903b22ec2a/bin/pkg_sql_tests benchdiff/f607041/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/f607041/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/21eed7b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/21eed7b292173de6e969083ab7042ef50628bc84/bin/pkg_sql_tests benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=21eed7b --new=f607041 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/f607041/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/f607041c5b440ebac46aae6e7a8166903b22ec2a/bin/pkg_sql_tests benchdiff/f607041/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/f607041/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/21eed7b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/21eed7b292173de6e969083ab7042ef50628bc84/bin/pkg_sql_tests benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=21eed7b --new=f607041 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/f607041/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/f607041c5b440ebac46aae6e7a8166903b22ec2a/bin/pkg_sql_tests benchdiff/f607041/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/f607041/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/21eed7b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/21eed7b292173de6e969083ab7042ef50628bc84/bin/pkg_sql_tests benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=21eed7b --new=f607041 ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/f607041c5b440ebac46aae6e7a8166903b22ec2a/19442096600-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/21eed7b292173de6e969083ab7042ef50628bc84/19442096600-1/\* old/built with commit: f607041c5b440ebac46aae6e7a8166903b22ec2a |
f607041 to
54d4caa
Compare
kyle-a-wong
commented
Nov 17, 2025
Contributor
Author
kyle-a-wong
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/sql/sqlstats/ssprovider.go line 86 at r1 (raw file):
Previously, dhartunian (David Hartunian) wrote…
why did this type change?
I originally moved some types around to get around import cycles when using supporting sql stats in UDFS / SPs, but I dont actually need to do it anymore so ive reverted all the updates that moved / updated types
pkg/sql/sqlstats/ssprovider.go line 161 at r2 (raw file):
nit: docstring would be nice. specifically I want to know about the requirements when constructing one of these. Can we skip all the builder pieces? Is there a minimum set?
Added a doc string to the struct definition and to the Build method. Also added some additional validation that will panic in test builds.
Also, why is the builder parameterized on
L? why can't just theLatencyRecordermethod accept aStatementLatencyRecorder?
You can't define methods with generics in golang the way you can in other languages, but I removed the generic in favor of the LatencyRecorder method just accepting the interface type.
pkg/sql/sqlstats/sslocal/sslocal_stats_collector.go line 42 at r2 (raw file):
Previously, dhartunian (David Hartunian) wrote…
huh, guess this is just unused?
Yeah, I think when Xin combined the insights and sql stats recording to both share the StatsCollector and StatsIngester, it also removed the need for this, but it was just never removed.
Member
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/54d4caa/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/54d4caa5e5a38ad6661c45462c6c2cedbaf8ea4a/bin/pkg_sql_tests benchdiff/54d4caa/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/54d4caa/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/21eed7b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/21eed7b292173de6e969083ab7042ef50628bc84/bin/pkg_sql_tests benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=21eed7b --new=54d4caa ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/54d4caa/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/54d4caa5e5a38ad6661c45462c6c2cedbaf8ea4a/bin/pkg_sql_tests benchdiff/54d4caa/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/54d4caa/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/21eed7b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/21eed7b292173de6e969083ab7042ef50628bc84/bin/pkg_sql_tests benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=21eed7b --new=54d4caa ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/54d4caa/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/54d4caa5e5a38ad6661c45462c6c2cedbaf8ea4a/bin/pkg_sql_tests benchdiff/54d4caa/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/54d4caa/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/21eed7b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/21eed7b292173de6e969083ab7042ef50628bc84/bin/pkg_sql_tests benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=21eed7b --new=54d4caa ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/54d4caa5e5a38ad6661c45462c6c2cedbaf8ea4a/19446682234-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/21eed7b292173de6e969083ab7042ef50628bc84/19446682234-1/\* old/built with commit: 54d4caa5e5a38ad6661c45462c6c2cedbaf8ea4a |
- Adds a new RecordedStatementStatsBuilder struct to make building RecordedStmtStats easier. - Moves the recording, buffering, and synchronization of sql stats to the ingester and removes the logic from StatsCollecotr Resolves: CRDB-57024 Epic: CRDB-55081 Release note: None
54d4caa to
5308d41
Compare
Member
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/5308d41/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/5308d41a1946741e2663f0a410ec54923767161c/bin/pkg_sql_tests benchdiff/5308d41/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/5308d41/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/21eed7b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/21eed7b292173de6e969083ab7042ef50628bc84/bin/pkg_sql_tests benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=21eed7b --new=5308d41 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/5308d41/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/5308d41a1946741e2663f0a410ec54923767161c/bin/pkg_sql_tests benchdiff/5308d41/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/5308d41/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/21eed7b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/21eed7b292173de6e969083ab7042ef50628bc84/bin/pkg_sql_tests benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=21eed7b --new=5308d41 ./pkg/sql/tests⚪ Sysbench [KV, 3node, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/5308d41/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/5308d41a1946741e2663f0a410ec54923767161c/bin/pkg_sql_tests benchdiff/5308d41/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/5308d41/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/21eed7b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/21eed7b292173de6e969083ab7042ef50628bc84/bin/pkg_sql_tests benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/21eed7b/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=21eed7b --new=5308d41 ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/5308d41a1946741e2663f0a410ec54923767161c/19471816808-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/21eed7b292173de6e969083ab7042ef50628bc84/19471816808-1/\* old/built with commit: 5308d41a1946741e2663f0a410ec54923767161c |
dhartunian
approved these changes
Nov 18, 2025
Collaborator
dhartunian
left a comment
There was a problem hiding this comment.
@dhartunian reviewed 1 of 31 files at r3, all commit messages.
Reviewable status:
Contributor
Author
|
tftr! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new RecordedStatementStatsBuilder was added to the sql package to make building a RecordedStmtStats struct easier.
New interfaces were also added to sqlstats to make make building RecordedStmtStats easier.
These new interfaces and builders should help to decouple Recording statement stats from the conn executor, allowing them to be recorded in other places as well
Epic: None
Release note: None