changefeedccl: Fix timestamp for descriptor fetches during changefeed…#155094
Draft
log-head wants to merge 2 commits intocockroachdb:masterfrom
Draft
changefeedccl: Fix timestamp for descriptor fetches during changefeed…#155094log-head wants to merge 2 commits intocockroachdb:masterfrom
log-head wants to merge 2 commits intocockroachdb:masterfrom
Conversation
… creation When a changefeed is planned and executed, there are several places where target table descriptors are fetched. With a db-level changefeed, the set of tables can change during changefeed startup. Now, the timestamp is set to the initial high water for retrieving table descriptors. Fixes: cockroachdb#154549 Epic: CRDB-1421 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
…feed test db-level changefeed test is not passing for fixing timestamp. This commit is a work in progress to solve that. Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… creation
When a changefeed is planned and executed, there are several places where target table descriptors are fetched. With a db-level changefeed, the set of tables can change during changefeed startup. Now, the timestamp is set to the initial high water for retrieving table descriptors. Fixes: #154549 Epic: CRDB-1421
Release note: None