Skip to content

roachest: ensure reader tenant accepts connections before restart#154369

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
msbutler:butler-deflake-reader-roachtests
Sep 29, 2025
Merged

roachest: ensure reader tenant accepts connections before restart#154369
craig[bot] merged 1 commit intocockroachdb:masterfrom
msbutler:butler-deflake-reader-roachtests

Conversation

@msbutler
Copy link
Copy Markdown
Collaborator

Previously, the roachtest would restart the tenant before the tenant could accept connections, which means the tenant could still be bootstrapping. Restarting the tenant service during bootstrap could lead to sadness, as outlined in #154356.

Informs #154356
Informs #154311
Informs #153131

Release note: none

@msbutler msbutler self-assigned this Sep 29, 2025
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Previously, the roachtest would restart the tenant before the tenant could
accept connections, which means the tenant could still be bootstrapping.
Restarting the tenant service during bootstrap could lead to sadness, as
outlined in cockroachdb#154356.

Informs cockroachdb#154356
Informs cockroachdb#154311
Informs cockroachdb#153131

Release note: none
@msbutler msbutler force-pushed the butler-deflake-reader-roachtests branch from 8a59477 to 20ea8e1 Compare September 29, 2025 15:24
@msbutler msbutler marked this pull request as ready for review September 29, 2025 16:46
Copy link
Copy Markdown
Collaborator

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msbutler
Copy link
Copy Markdown
Collaborator Author

TFTR!

bors r=jeffswenson

@msbutler msbutler added the backport-25.4.x Flags PRs that need to be backported to 25.4 label Sep 29, 2025
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 29, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-25.4.x Flags PRs that need to be backported to 25.4 v26.1.0-prerelease

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants