roachtest: add github issue posting dry run mode#154164
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 29, 2025
Merged
roachtest: add github issue posting dry run mode#154164craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
williamchoe3
approved these changes
Sep 25, 2025
pkg/cmd/roachtest/github.go
Outdated
| if skipReason != "" { | ||
| l.Printf("skipping GitHub issue posting (%s)", skipReason) | ||
| return nil, nil | ||
| if !g.dryRun { |
Contributor
There was a problem hiding this comment.
nit: this would be more verbose, but i feel like having a maybePostDryRun function would make this a little bit easier to follow vs the branching bool logic, but the branches aren't that crazy so ok with how it is now
herkolategan
approved these changes
Sep 26, 2025
Collaborator
|
LGTM, barring the |
bb6d106 to
6d19f79
Compare
We already have the functionality in datadriven tests to render github issue post requests as clickable links. This change extends that functionality to roachtests in the form of a --dry-run-issue-posting flag. This allows for viewing what the output of a failed roachtest would look like even if github posting is disabled.
6d19f79 to
90f80fa
Compare
Contributor
Author
|
TFTR! bors r=williamchoe3, herkolategan |
Contributor
Author
|
looks like bors skipped me? 😕 bors cancel |
Contributor
Author
|
bors r=williamchoe3,herkolategan |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have the functionality in datadriven tests to render github issue post requests as clickable links. This change extends that functionality to roachtests in the form of a --dry-run-issue-posting flag. This allows for viewing what the output of a failed roachtest would look like even if github posting is disabled.
Fixes: none
Release note: none
Epic: none