distsql: fix span resolver panic#15413
Merged
RaduBerinde merged 1 commit intocockroachdb:masterfrom Apr 27, 2017
Merged
Conversation
Member
|
This change is |
Fixing an incorrect check in `Seek()`. We want to reuse the last descriptor if it contains the key, not if the old span we were partitioning does. Adding some verbose logging messages too. I have a test that was causing the panic in a different change I'm working on, so I'm not adding a dedicated test here. Fixes cockroachdb#15352.
43fe790 to
e9a949c
Compare
Contributor
|
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing an incorrect check in
Seek(). We want to reuse the last descriptor ifit contains the key, not if the old span we were partitioning does. Adding some
verbose logging messages too.
I have a test that was causing the panic in a different change I'm working on,
so I'm not adding a dedicated test here.
Fixes #15352.