workload/schemachange: handle LTREE in mixed version CREATE TYPE#152170
workload/schemachange: handle LTREE in mixed version CREATE TYPE#152170craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Using this type in a composite type in a mixed version cluster will cause UndefinedObject errors, so we need to make the workload aware of that. Release note: None
|
This change is |
fqazi
left a comment
There was a problem hiding this comment.
@fqazi reviewed 1 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @DarrylWong and @srosenberg)
pkg/workload/schemachange/operation_generator.go line 1371 at r1 (raw file):
hasTypeWithPrefix := func(typePrefix string) bool { for _, field := range statement.CompositeTypeList { if strings.HasPrefix(field.Type.SQLString(), typePrefix) {
Would this also work on arrays?
fqazi
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/workload/schemachange/operation_generator.go line 1371 at r1 (raw file):
Previously, fqazi (Faizan Qazi) wrote…
Would this also work on arrays?
Or is that not a concern
fqazi
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/workload/schemachange/operation_generator.go line 1371 at r1 (raw file):
Previously, fqazi (Faizan Qazi) wrote…
Or is that not a concern
Done.
Nevermind this will work correctly, I mixed up the syntax in my head.
|
tftr! bors r+ |
|
Build succeeded: |
Using this type in a composite type in a mixed version cluster will cause UndefinedObject errors, so we need to make the workload aware of that.
informs #150547
Release note: None