roachtest: fix nil team loader#150223
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 15, 2025
Merged
Conversation
During the migration of the github poster initialization in cockroachdb#149479, the default team loader configuration was inadvertently omitted. This change restores the default team loader setting to resolve the issue. Informs: cockroachdb#149479 Epic: None Release note: None
Member
|
This change is |
Collaborator
Author
Contributor
|
Oh no sorry! Taking a look now |
williamchoe3
approved these changes
Jul 15, 2025
Contributor
williamchoe3
left a comment
There was a problem hiding this comment.
Thanks for catching and fixing this! When splitting githubIssues into githubIssueInfo this slipped through the cracks.
Checked the unit tests in github_test.go for some sanity checking, in TestShouldPost it's being passed in correctly, so I suppose that's why the unit tests passed for me.
And my new test in test_test.go TestRunnerProvisionErrorGithubError, it mocks MaybePost so it never hits the point where we need teamLoader.
srosenberg
approved these changes
Jul 15, 2025
Collaborator
Author
|
TFTRs! bors r=williamchoe3,srosenberg |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the migration of the github poster initialization in #149479, the default team loader configuration was inadvertently omitted. This change restores the default team loader setting to resolve the issue.
Informs: #149479
Epic: None
Release note: None