kvstorage: fix CreateUninitializedReplica comment#150189
kvstorage: fix CreateUninitializedReplica comment#150189craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
arulajmani
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @tbg)
pkg/kv/kvserver/kvstorage/replica_state.go line 140 at r1 (raw file):
// // Before this point, raft and state machine state of this replica are // non-existing. The only RangeID-specific key that can be present is the
nit: "non-existant"
The scenario described in the comment was possible before it became an invariant that all replicas have a RaftReplicaID in storage. Since we completed a migration which established this invariant, we can remove this comment. Epic: none Release note: none
91b87b8 to
f66721f
Compare
|
TFTR! bors r=arulajmani |
pav-kv
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/kv/kvserver/kvstorage/replica_state.go line 140 at r1 (raw file):
Previously, arulajmani (Arul Ajmani) wrote…
nit: "non-existant"
Done.
"non-existent", according to https://en.wiktionary.org/wiki/existant 😆
|
bors retry |
The scenario described in the comment was possible before it became an invariant that all replicas have a
RaftReplicaIDin storage. Since we completed a migration [#95513] which established this invariant, we can remove this comment.Historical context: https://github.com/cockroachdb/cockroach/pull/75761/files#diff-208036c53fab5274d107185f7b974421738b6cd54b849000a60656c764ba2b08R224-R272
Epic: none
Release note: none