crosscluster/physical: persist standby poller progress#149913
crosscluster/physical: persist standby poller progress#149913craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
d54c3b1 to
660ae2f
Compare
This patch sets the standby poller job's resolved time to the system time that standby descriptors have been updated to. This allows a reader tenant user to easily check that the poller job is running smoothly via SHOW JOB. Epic: none Release note: none
660ae2f to
b9b328a
Compare
Epic: none Release note: none
b9b328a to
d8d8fa4
Compare
|
I'll grant that this is quick and easy, but I question if Should we add something like |
100% agree. I need this patch to add some roachtest logic to ensure the stanby poller advances. Moving forward, I plan to write up a doc in the next few days exploring where our reader tenant UX should go. |
|
if it is just for a test, you can just crdb_internal it can't you? |
|
before this PR, we didn't persist any progress for the standby poller job. |
|
we don't persist progress but the timestamp you're persisting here is persisted in the catalog: on 24.3+: |
|
ah right. I still feel good landing this PR so the UX in this intermediate stage is slightly better than conducting pb to json gymnastics during some escalation. |
|
I don't think meets the new backport policy though? |
|
Chatted offline. we're fine merging this now even if this is intermediate. bors r=dt |
This patch sets the standby poller job's resolved time to the system time that standby descriptors have been updated to. This allows a reader tenant user to easily check that the poller job is running smoothly via SHOW JOB.
Epic: none
Release note: none