roachtest: use from version for workload#147377
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom May 28, 2025
Merged
roachtest: use from version for workload#147377craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
0ec70cb to
50316c6
Compare
Collaborator
Author
|
TeamCity run with the same seed (-7112154562575888906) that failed, previously: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_RoachtestNightlyGceBazel/19796609 |
stevendanna
approved these changes
May 28, 2025
Collaborator
stevendanna
left a comment
There was a problem hiding this comment.
Awesome, thanks for tackling this one!
Previously, `rebalance/by-load/leases/mixed-version` used the master workload binary. This caused compatibility issue with mixed version tests. This change uploads the `from version` workload binary to the cluster, before running the workload. Fixes: cockroachdb#147250 Informs: cockroachdb#147374 Epic: None Release note: None
Epic: None Release note: None
f3e184a to
fdb6651
Compare
Collaborator
Author
|
TFTR! bors r=stevendanna |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
rebalance/by-load/leases/mixed-versionused the master workload binary. This caused compatibility issue with mixed version tests. This change uploads thefrom versionworkload binary to the cluster, before running the workload.Fixes: #147250
Informs: #147374
Epic: None
Release note: None