Skip to content

logictest: deflake recent addition to select_for_update#145984

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
michae2:b144830
May 6, 2025
Merged

logictest: deflake recent addition to select_for_update#145984
craig[bot] merged 1 commit intocockroachdb:masterfrom
michae2:b144830

Conversation

@michae2
Copy link
Copy Markdown
Collaborator

@michae2 michae2 commented May 2, 2025

The testcases I added in #144449 depend on a large enough batch size to match the expected tracing.

Fixes: #144830

Release note: None

The testcases I added in cockroachdb#144449 depend on a large enough batch size to
match the expected tracing.

Fixes: cockroachdb#144830

Release note: None
@michae2 michae2 added the backport-25.2.x Flags PRs that need to be backported to 25.2 label May 2, 2025
@michae2 michae2 requested review from a team and mw5h and removed request for a team May 2, 2025 17:58
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@michae2 michae2 requested a review from yuzefovich May 2, 2025 17:59
Copy link
Copy Markdown
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mw5h)

@yuzefovich
Copy link
Copy Markdown
Member

bors r=yuzefovich

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 6, 2025

@craig craig bot merged commit c4638a9 into cockroachdb:master May 6, 2025
22 checks passed
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented May 6, 2025

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #144830: branch-release-25.2.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-25.2.x Flags PRs that need to be backported to 25.2 v25.3.0-prerelease

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pkg/sql/logictest/tests/local-mixed-24.3/local-mixed-24_3_test: TestLogic_select_for_update failed

3 participants