server: add EngineStats endpoint in multitenant setup#143633
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 10, 2025
Merged
server: add EngineStats endpoint in multitenant setup#143633craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
shubhamdhama
reviewed
Apr 7, 2025
shubhamdhama
reviewed
Apr 7, 2025
shubhamdhama
reviewed
Apr 7, 2025
shubhamdhama
requested changes
Apr 7, 2025
Contributor
shubhamdhama
left a comment
There was a problem hiding this comment.
I've left some minor comments above. The rest of the PR looks good to me.
cthumuluru-crdb
requested changes
Apr 8, 2025
Contributor
cthumuluru-crdb
left a comment
There was a problem hiding this comment.
Left a couple of comments. Otherwise it looks good.
cthumuluru-crdb
requested changes
Apr 8, 2025
Contributor
cthumuluru-crdb
left a comment
There was a problem hiding this comment.
Left a couple of comments. Otherwise it looks good.
4f26617 to
9842bc9
Compare
EngineStats endpoint was inaccessible from secondary tenant. EngineStats endpoint provides statistics of storage layer which can help diagnose myriad of issues critical to database performance. To address this, we created EngineStatus endpoint in tenant status server. Implementation uses tenant connector to redirect call to system status server on requested kv node. Access to this endpoint is guarded by `can_view_node_info` capability as this endpoint returns info of all stores on a given node. Updated corresponding unit tests. Epic: CRDB-38968 Fixes: cockroachdb#110020 Part of: CRDB-31226 Release note: None
Contributor
Author
|
bors r=shubhamdhama,cthumuluru-crdb |
Contributor
|
👎 Rejected by code reviews |
cthumuluru-crdb
approved these changes
Apr 10, 2025
Contributor
cthumuluru-crdb
left a comment
There was a problem hiding this comment.
LGTM. Thank you!
Contributor
Author
|
bors r=shubhamdhama,cthumuluru-crdb |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EngineStats endpoint was inaccessible from secondary tenant.
EngineStats endpoint provides statistics of storage layer which can help diagnose myriad of issues critical to database performance.
To address this, we created EngineStatus endpoint in tenant status server. Implementation uses tenant connector to redirect call to system status server on requested kv node. Access to this endpoint is guarded by
can_view_node_infocapability as this endpoint returns info of all stores on a given node. Updated corresponding unit tests.Epic: CRDB-38968
Fixes: #110020
Release note: None