raft: use term cache for leader commit term check#143424
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Mar 26, 2025
Merged
raft: use term cache for leader commit term check#143424craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Previously, we avoided calling term(index) for leader commit term check by keeping the first entry index for the current leader term in memory, and comparing against that index. (see cockroachdb#137826) Now, since we have implemented term cache (which stores info of the current leader term's first entryID in this case), the term cache is used for that check to reduce the complexity of our code. (see cockroachdb#142239 ) Part of cockroachdb#136296 Fixes: cockroachdb#143362 Epic: None Release note: None
Member
|
This change is |
pav-kv
approved these changes
Mar 25, 2025
pav-kv
reviewed
Mar 25, 2025
2bab00d to
eee2d2f
Compare
pav-kv
approved these changes
Mar 26, 2025
Contributor
Author
|
tyfr! bors r=pav-kv |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we avoided calling term(index) for leader commit term check by keeping the first entry index for the current leader term in memory, and comparing against that index. (see #137826)
Now, since we have implemented term cache
(which stores info of the current leader term's first entryID in this case), the term cache is used for that check to reduce the complexity of our code. (see #142239 )
Part of #136296
Fixes: #143362
Epic: None
Release note: None