upgrades: report progress during 25.1 upgrade jobs backfill#141833
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Feb 21, 2025
Merged
upgrades: report progress during 25.1 upgrade jobs backfill#141833craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
When upgrades are running in real, non-test setups, they run in jobs. This change passes the job ID, when it exists, to the upgrade func in its deps struct, though the field name reflects that it can be absent (as in tests). This allows the upgrade func to elect to load and use/mutate the job if it so chooses. Release note: none. Epic: none.
Release note: none. Epic: none.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
|
Examples: Logs: |
Contributor
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/5a2139b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/5a2139b19e818a29a21333550421ac8a8862c2ab/bin/pkg_sql_tests benchdiff/5a2139b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/5a2139b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/3690e14/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/3690e1479b9747dd361fe10cd9b1ba0adff91e89/bin/pkg_sql_tests benchdiff/3690e14/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/3690e14/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=3690e14 --new=5a2139b ./pkg/sql/tests⚪ Sysbench [KV, 1node, local, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/5a2139b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/5a2139b19e818a29a21333550421ac8a8862c2ab/bin/pkg_sql_tests benchdiff/5a2139b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/5a2139b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/3690e14/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/3690e1479b9747dd361fe10cd9b1ba0adff91e89/bin/pkg_sql_tests benchdiff/3690e14/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/3690e14/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_read_only$ --old=3690e14 --new=5a2139b ./pkg/sql/tests⚪ Sysbench [KV, 1node, local, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/5a2139b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/5a2139b19e818a29a21333550421ac8a8862c2ab/bin/pkg_sql_tests benchdiff/5a2139b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/5a2139b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/3690e14/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/3690e1479b9747dd361fe10cd9b1ba0adff91e89/bin/pkg_sql_tests benchdiff/3690e14/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/3690e14/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_write_only$ --old=3690e14 --new=5a2139b ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/5a2139b19e818a29a21333550421ac8a8862c2ab/13458923467-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/3690e1479b9747dd361fe10cd9b1ba0adff91e89/13458923467-1/\* old/Legend
No regressions detected! built with commit: 5a2139b19e818a29a21333550421ac8a8862c2ab |
msbutler
approved these changes
Feb 21, 2025
Contributor
Author
|
TFTR! bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: none.
Epic: none.