sql: increase tenant testing coverage#141604
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 21, 2025
Merged
Conversation
Member
|
This change is |
rafiss
approved these changes
Feb 18, 2025
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
the pkg/sql changes lgtm, but some of these tests are owned by the SQL Queries and DR teams, so they should take a look.
yuzefovich
approved these changes
Feb 18, 2025
Member
yuzefovich
left a comment
There was a problem hiding this comment.
2nd commit
Reviewed 15 of 15 files at r1, 16 of 16 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong, @golgeek, @kev-cao, @kyle-a-wong, @mgartner, and @wenyihu6)
(Stacked on cockroachdb#141490.) This PR continues the work from cockroachdb#140447, replacing occurrences of `createTestServerParams` with `createTestServerParamsAllowTenants` to enable tenant testing in these tests. Informs: cockroachdb#140446 Epic: CRDB-38970 Release note: None
bf68b79 to
6f2435c
Compare
Contributor
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/6f2435c/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/6f2435c712e4ca5c7b72293bfb605a1f70bb998d/bin/pkg_sql_tests benchdiff/6f2435c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/6f2435c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/fbcabe0/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/fbcabe029eb2e1701710d08cebbca6d15089f911/bin/pkg_sql_tests benchdiff/fbcabe0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/fbcabe0/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=fbcabe0 --new=6f2435c ./pkg/sql/tests⚪ Sysbench [KV, 1node, local, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/6f2435c/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/6f2435c712e4ca5c7b72293bfb605a1f70bb998d/bin/pkg_sql_tests benchdiff/6f2435c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/6f2435c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/fbcabe0/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/fbcabe029eb2e1701710d08cebbca6d15089f911/bin/pkg_sql_tests benchdiff/fbcabe0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/fbcabe0/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_read_only$ --old=fbcabe0 --new=6f2435c ./pkg/sql/tests⚪ Sysbench [KV, 1node, local, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/6f2435c/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/6f2435c712e4ca5c7b72293bfb605a1f70bb998d/bin/pkg_sql_tests benchdiff/6f2435c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/6f2435c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/fbcabe0/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/fbcabe029eb2e1701710d08cebbca6d15089f911/bin/pkg_sql_tests benchdiff/fbcabe0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/fbcabe0/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_write_only$ --old=fbcabe0 --new=6f2435c ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/6f2435c712e4ca5c7b72293bfb605a1f70bb998d/13456892060-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/fbcabe029eb2e1701710d08cebbca6d15089f911/13456892060-1/\* old/Legend
No regressions detected! built with commit: 6f2435c712e4ca5c7b72293bfb605a1f70bb998d |
Contributor
Author
|
After removing the stacked commit, it seems there are no remaining changes that would affect the DR team. So, we should be good to merge. Thanks for the reviews! bors r =rafiss,yuzefovich |
Contributor
Author
|
Oops! bors r=rafiss,yuzefovich |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the work from #140447, replacing occurrences of
createTestServerParamswithcreateTestServerParamsAllowTenantsto enable tenant testing in these tests.
Informs: #140446
Epic: CRDB-38970
Release note: None