sqlstats: Reuse sessionphase.Times on stats collector#141392
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 14, 2025
Merged
sqlstats: Reuse sessionphase.Times on stats collector#141392craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Contributor
Author
|
This function kept popping up in the sqlstats section of cpu/mem profiles. Super minor improvement if any. |
Collaborator
|
@xinhaoz which function? can you put the info in the commit msg |
StatsCollector.Reset shows up in sqlstats section of cpu/mem profiles. This seemed to mostly be allocations of new session.PhaseTimes objects. This commit avoids new allocations of session.PhaseTimes when resetting the stats collector. Epic: none Release note: None
Contributor
🟢 Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/da8224e/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/da8224e7106bec44a9ab4211a1cc4caaea1ed986/bin/pkg_sql_tests benchdiff/da8224e/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/da8224e/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/d23e5d4/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/d23e5d4bdaed6204c58207c4d004a13fe652fa71/bin/pkg_sql_tests benchdiff/d23e5d4/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/d23e5d4/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=d23e5d4 --new=da8224e ./pkg/sql/tests⚪ Sysbench [KV, 1node, local, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/da8224e/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/da8224e7106bec44a9ab4211a1cc4caaea1ed986/bin/pkg_sql_tests benchdiff/da8224e/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/da8224e/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/d23e5d4/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/d23e5d4bdaed6204c58207c4d004a13fe652fa71/bin/pkg_sql_tests benchdiff/d23e5d4/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/d23e5d4/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_read_only$ --old=d23e5d4 --new=da8224e ./pkg/sql/tests⚪ Sysbench [KV, 1node, local, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/da8224e/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/da8224e7106bec44a9ab4211a1cc4caaea1ed986/bin/pkg_sql_tests benchdiff/da8224e/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/da8224e/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/d23e5d4/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/d23e5d4bdaed6204c58207c4d004a13fe652fa71/bin/pkg_sql_tests benchdiff/d23e5d4/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/d23e5d4/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_write_only$ --old=d23e5d4 --new=da8224e ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/da8224e7106bec44a9ab4211a1cc4caaea1ed986/13295590003-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/d23e5d4bdaed6204c58207c4d004a13fe652fa71/13295590003-1/\* old/Legend
No regressions detected! built with commit: da8224e7106bec44a9ab4211a1cc4caaea1ed986 |
dhartunian
approved these changes
Feb 14, 2025
Collaborator
dhartunian
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @angles-n-daemons)
Contributor
Author
|
tftr! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatsCollector.Reset shows up in sqlstats section of cpu/mem
profiles. This seemed to mostly be allocations of new session.PhaseTimes
objects. This commit avoids new allocations of session.PhaseTimes
when resetting the stats collector.
Epic: none
Release note: None