sql: enable tenant testing for schema_changer tests#141213
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 14, 2025
Merged
sql: enable tenant testing for schema_changer tests#141213craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously all tests in this file were disabled for multitenancy. (Continuation of cockroachdb#140447 for `schema_changer_test.go`) Informs: cockroachdb#140446 Epic: CRDB-38970 Release note: None
Member
|
This change is |
Contributor
Author
|
The affected tests in this PR don't take that much longer in shared tenant mode compared to single tenant (70s vs ~80s). But, like a lot of other tests, external process mode is a different story (~180s). |
rafiss
approved these changes
Feb 14, 2025
Contributor
Author
|
TFTR! bors r=cthumuluru-crdb,rafiss |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously all tests in this file were disabled for multitenancy.
(Continuation of #140447 for
schema_changer_test.go)Informs: #140446
Epic: CRDB-38970
Release note: None