sql: deflake TestBackfillWithProtectedTS#141196
sql: deflake TestBackfillWithProtectedTS#141196craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
3b42c0a to
3ba5300
Compare
- Using different tables for each subtest makes the tests more isolated from each other. - Add a primary key to the table to avoid ever using a secondary index. - Delete in batches instead of all at once. This makes the delete operation less likely to experience contention. I verified this deflaked the test by running the test on EngFlow with ``` ./dev test pkg/sql -f=TestBackfillWithProtectedTS --stress --count=10000 ``` Release note: None
3ba5300 to
86f5e32
Compare
Dedej-Bergin
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
|
bors r+ |
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #139991: branch-release-23.2, branch-release-24.1, branch-release-24.3, branch-release-25.1. Issue #139901: branch-release-23.2, branch-release-24.1, branch-release-25.1. Issue #139862: branch-release-23.2, branch-release-24.1, branch-release-24.3. Issue #139814: branch-release-23.2, branch-release-24.1, branch-release-24.3, branch-release-25.1. Issue #140043: branch-release-23.2, branch-release-24.3, branch-release-25.1. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 86f5e32 to blathers/backport-release-23.2-141196: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2.x failed. See errors above. error creating merge commit from 86f5e32 to blathers/backport-release-24.1-141196: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.1.x failed. See errors above. error creating merge commit from 86f5e32 to blathers/backport-release-24.3-141196: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.3.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
isolated from each other.
operation less likely to experience contention.
I verified this deflaked the test by running the test on EngFlow with
fixes #139814
fixes #140043
fixes #139991
fixes #139901
fixes #139862
Release note: None