Reviewed 3 of 3 files at r1, 5 of 5 files at r2.
Review status: 7 of 10 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

pkg/sql/app_stats.go, line 50 at r2 (raw file):

}

func (a *appStats) registerQuery() {

I'm not fond of the name registerQuery as that makes me think you're registering some callback or something like that. Also, this is being called for each SQL statement, not just queries. How about recordStatement? And the call site also knows whether the statement was successful or an error, so perhaps this should be recordStatement(err error).

pkg/sql/crdb_internal.go, line 235 at r3 (raw file):

CREATE TABLE crdb_internal.app_stats (
  APPLICATION_NAME STRING,
  QUERY_COUNT      INT

STATEMENT_COUNT? Also, I thought we used lowercase for column names.

Comments from Reviewable

Review status: 7 of 10 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

pkg/sql/app_stats.go, line 50 at r2 (raw file):

Done.

pkg/sql/crdb_internal.go, line 235 at r3 (raw file):

Done (we don't use lowercase for virtual tables, for some reason).

Comments from Reviewable