Skip to content

sql: support setting an application name for a session.#14085

Merged
knz merged 3 commits intocockroachdb:masterfrom
knz:app-name
Mar 10, 2017
Merged

sql: support setting an application name for a session.#14085
knz merged 3 commits intocockroachdb:masterfrom
knz:app-name

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Mar 10, 2017

Needed for #13968.


This change is Reviewable

@knz knz requested review from dt and jordanlewis March 10, 2017 22:54
@jordanlewis
Copy link
Copy Markdown
Member

:lgtm:


Reviewed 4 of 4 files at r1, 1 of 1 files at r2, 5 of 5 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.


pkg/sql/session.go, line 72 at r2 (raw file):

	//

	// Database indicates the "current" database for the purpose

Is it worth mentioning how this interacts with the session search path?


pkg/sql/session.go, line 100 at r2 (raw file):

	TxnState txnState
	// PreparedStatement and PreparedPortals store the statements/portals
	// that have been configured via pgwire.

PreparedStatement should be plural, also maybe just say "prepared" via pgwire?


Comments from Reviewable

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Mar 10, 2017

TFYR


Review status: 1 of 6 files reviewed at latest revision, 2 unresolved discussions.


pkg/sql/session.go, line 72 at r2 (raw file):

Previously, jordanlewis (Jordan Lewis) wrote…

Is it worth mentioning how this interacts with the session search path?

Done.


pkg/sql/session.go, line 100 at r2 (raw file):

Previously, jordanlewis (Jordan Lewis) wrote…

PreparedStatement should be plural, also maybe just say "prepared" via pgwire?

Done.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants