sql: refactor unimplemented statements into one file pkg/sql/unimplem…#137795
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
|
|
This change is |
613db3e to
a902933
Compare
|
Wanted to point out that I removed |
a902933 to
f05721f
Compare
rafiss
left a comment
There was a problem hiding this comment.
this lgtm! except the PR says Fixes: #45671, but that looks like the wrong link.
…ented.go Moved files with unimplemented stubs into just 1 file unimplemented.go. These unimplemented stubs work in DSC only and we will not implement them on the legacy schema changer. Fixes: cockroachdb#137615 Release note: none
f05721f to
71fab67
Compare
Dedej-Bergin
left a comment
There was a problem hiding this comment.
Thanks for the review! I accidentally put the jira issue number instead of the github one. Just updated it.
Reviewable status:
complete! 0 of 0 LGTMs obtained
|
bors r+ |
…ented.go
Moved files with unimplemented stubs into just 1 file unimplemented.go. These unimplemented stubs work in DSC only and we will not implement them on the legacy schema changer.
Fixes: #137615
Release note: none