props: don't leave unmerged equiv groups in EquivSet#137558
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 17, 2024
Merged
props: don't leave unmerged equiv groups in EquivSet#137558craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit fixes a bug in `EquivSet.tryMergeGroups`, which could cause an invariant (that equiv groups are non-intersecting) to be violated. This would potentially cause re-ordered joins to have redundant equality filters, and prevent join filter push-down in rare cases. This commit also adds verification to the set for test builds, and a unit test for the `Add` method. Fixes cockroachdb#137381 Release note: None
Member
|
This change is |
mgartner
approved these changes
Dec 16, 2024
Contributor
mgartner
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
Collaborator
Author
|
TFTR! bors r+ |
This was referenced Dec 17, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in
EquivSet.tryMergeGroups, which could cause an invariant (that equiv groups are non-intersecting) to be violated. This would potentially cause re-ordered joins to have redundant equality filters, and prevent join filter push-down in rare cases. This commit also adds verification to the set for test builds, and a unit test for theAddmethod.Fixes #137381
Release note: None