sql/stats: enable automatic collection of partial table stats#133988
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 31, 2024
Merged
sql/stats: enable automatic collection of partial table stats#133988craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
In cockroachdb#93067 we added support for automatic collection of partial stats. This commit enables automatic collection of partial stats by default. Release note (sql change): This commit turns on cluster setting `sql.stats.automatic_partial_collection.enabled` by default, which enables automatic collection of partial table stats. Partial table stats (i.e. those created with `CREATE STATISTICS ... USING EXTREMES`) scan the lower and upper ends of indexes to collect statistics outside the range covered by the previous full statistics collection.
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
rytaft
approved these changes
Oct 31, 2024
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
Collaborator
Author
|
bors r=rytaft |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #93067 we added support for automatic collection of partial stats. This commit enables automatic collection of partial stats by default.
Epic: None
Release note (sql change): This commit turns on cluster setting
sql.stats.automatic_partial_collection.enabledby default, which enables automatic collection of partial table stats. Partial table stats (i.e. those created withCREATE STATISTICS ... USING EXTREMES) scan the lower and upper ends of indexes to collect statistics outside the range covered by the previous full statistics collection.