roachtest: update generate-fixtures to use clusterupgrade functions#131467
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 27, 2024
Merged
Conversation
This commit updates the `generate-fixtures` roachtest, used to automate the generation of fixtures every release, so that it uses plain `clusterupgrade` functions instead of the `newUpgradeTest` API. The old "step" functions only provided thin wrappers around the functionality of `clusterupgrade`. With this change, we are now able to completely remove the `newUpgradeTest` API which has been deprecated for a while in favor of the `mixedversion` framework. Fixes: cockroachdb#110528 Release note: None
Member
|
This change is |
Author
|
Ran |
13 tasks
Author
|
TFTR! bors r=srosenberg |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the
generate-fixturesroachtest, used to automate the generation of fixtures every release, so that it uses plainclusterupgradefunctions instead of thenewUpgradeTestAPI.The old "step" functions only provided thin wrappers around the functionality of
clusterupgrade. With this change, we are now able to completely remove thenewUpgradeTestAPI which has been deprecated for a while in favor of themixedversionframework.Fixes: #110528
Release note: None