roachtest: port decommission/mixed-versions#131252
roachtest: port decommission/mixed-versions#131252craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
8dc822a to
083ca0c
Compare
| // considered suspect unnecessarily. | ||
| sleepStep(2*suspectDuration), | ||
|
|
||
| // Partially decommission a random node from another random node. We |
There was a problem hiding this comment.
What was reasoning for getting rid of the randomness in node choice here? It also means we won't ever do a self decommission in this test right?
There was a problem hiding this comment.
Mostly because the randomness is now "built-in". In each run of this test, the versions running on n1 and n2 could be any combination of {old, new} x {old, new}.
Good catch on self decommission, I added that in.
083ca0c to
ecbd7b3
Compare
This commit ports the `decommission/mixed-versions` roachtest to use the `mixedversion` framework (instead of the old `newUpgradeTest` API). It also updates `acceptance/decommission-self` since both tests used shared functionality that needed to be updated. Prior to this commit, the acceptance test used the old upgrade test API even though it was not an upgrade test. Fixes: cockroachdb#110531 Fixes: cockroachdb#110530 Release note: None
ecbd7b3 to
b6b6db6
Compare
|
5 more runs passed after the change to add FYI @cockroachdb/kv: the TFTR! bors r=srosenberg,DarrylWong |
This commit ports the
decommission/mixed-versionsroachtest to use themixedversionframework (instead of the oldnewUpgradeTestAPI). It also updatesacceptance/decommission-selfsince both tests used shared functionality that needed to be updated. Prior to this commit, the acceptance test used the old upgrade test API even though it was not an upgrade test.Fixes: #110531
Fixes: #110530
Release note: None