Skip to content

hlc: remove Timestamp.EqOrdering#128428

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/tsEqOrdering
Aug 7, 2024
Merged

hlc: remove Timestamp.EqOrdering#128428
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/tsEqOrdering

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Aug 7, 2024

Addresses a TODO.
This method has been unnecessary since synthetic timestamps were removed in #116830.

Epic: None
Release note: None

Addresses a TODO.
This method has been unnecessary since synthetic timestamps were removed
in cockroachdb#116830.

Release note: None
@nvb nvb requested a review from miraradeva August 7, 2024 01:31
@nvb nvb requested review from a team as code owners August 7, 2024 01:31
@nvb nvb requested review from RaduBerinde, dt and rharding6373 and removed request for a team August 7, 2024 01:31
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @dt, @miraradeva, and @RaduBerinde)

@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented Aug 7, 2024

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 7, 2024

@craig craig bot merged commit e580b0f into cockroachdb:master Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants