sql: disable partial stats at extremes for enum and bool columns#126500
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 2, 2024
Conversation
Enums and bool types have arbitrary orderings, so it doesn't make sense to collect stats `USING EXTREMES` (scanning beyond the previous max and min) for these column types. Adds the `enable_create_stats_using_extremes_bool_enum` session setting to allow creating partial stats at extremes on bool and enum columns, which is disabled by default. Fixes: cockroachdb#126401 See also: cockroachdb#125950 Release note: None
Member
|
This change is |
DrewKimball
approved these changes
Jul 1, 2024
Collaborator
DrewKimball
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Uzair5162)
Contributor
Author
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enums and bool types have arbitrary orderings, so it doesn't make sense to collect stats
USING EXTREMES(scanning beyond the previous max and min) for these column types. Adds theenable_create_stats_using_extremes_bool_enumsession setting to allow creating partial stats at extremes on bool and enum columns, which is disabled by default.Fixes: #126401
See also: #125950
Release note: None