kvadmission: remove grunning non-monotonic comment#126424
kvadmission: remove grunning non-monotonic comment#126424craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This was fixed in cockroachdb#118907. This patch adds an assertion for test builds to ensure monotonic grunning time. Informs cockroachdb#95529 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @aadityasondhi)
pkg/kv/kvserver/kvadmission/kvadmission.go line 455 at r1 (raw file):
if ah.callAdmittedWorkDoneOnKVAdmissionQ { cpuTime := grunning.Time() - ah.cpuStart if buildutil.CrdbTestBuild && cpuTime < 0 {
if someone uses an unpatched runtime, will cpuTime be 0?
aadityasondhi
left a comment
There was a problem hiding this comment.
TFTR!
bors r=sumeerbhola
Reviewable status:
pkg/kv/kvserver/kvadmission/kvadmission.go line 455 at r1 (raw file):
Previously, sumeerbhola wrote…
if someone uses an unpatched runtime, will
cpuTimebe 0?
Yes. Both grunning.Time() and ah.cpuStart will be 0 in unpatched versions.
ah.cpuStart = grunning.Time()
|
bors r+ |
This was fixed in #118907.
This patch adds an assertion for test builds to ensure monotonic grunning time.
Informs #95529
Release note: None