roachtest: add test for admission control disk bandwidth #124160
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 21, 2024
Merged
roachtest: add test for admission control disk bandwidth #124160craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
b856133 to
3d01c24
Compare
744a03d to
8c17890
Compare
This test runs a single node target cluster that has two workloads running on it. The lower priority (qos=background) is very bandwidth intensive, and without the AC bandwidth limiter would saturate the provisioned bandwidth (controlled using cgroups). This test shows how setting the cluster setting `kvadmission.store.provisioned-bandwidth` limits the disk bandwidth usage of lower priority work and shapes it at the value set in the setting. Fixes cockroachdb#121576. Release note: None
8c17890 to
f23b867
Compare
Contributor
Author
|
Link to grafana dashboard showing this. Note: I manually adjusted setting in that run to show how the shaping is working. In this test, we set those limits right away and assert on never going too far past the provisioned limit. |
sumeerbhola
approved these changes
May 21, 2024
Collaborator
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nameisbhaskar and @vidit-bhat)
aadityasondhi
commented
May 21, 2024
Contributor
Author
aadityasondhi
left a comment
There was a problem hiding this comment.
TFTR!
bors r=sumeerbhola
Reviewable status:
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test runs a single node target cluster that has two workloads
running on it. The lower priority (qos=background) is very bandwidth
intensive, and without the AC bandwidth limiter would saturate the
provisioned bandwidth (controlled using cgroups).
This test shows how setting the cluster setting
kvadmission.store.provisioned-bandwidthlimits the disk bandwidthusage of lower priority work and shapes it at the value set in the
setting.
Fixes #121576.
Release note: None