roachtest: expand and cloudify cdc/initial-scan-rolling-restart#123924
roachtest: expand and cloudify cdc/initial-scan-rolling-restart#123924craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
68bf16e to
6a8ba94
Compare
This patch expands the `cdc/initial-scan-rolling-restart` test to also test normal checkpoints (in addition to shutdown checkpoints). It also updates the test to work on GCE so that it can run during nightly CI. Release note: None
498094a to
d4ef147
Compare
rharding6373
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong, @dt, @renatolabs, and @wenyihu6)
wenyihu6
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/tests/cdc.go line 1291 at r1 (raw file):
Name: "cdc/initial-scan-rolling-restart", Owner: registry.OwnerCDC, Cluster: r.MakeClusterSpec(5),
Out of curiosity, any reasons you changed it to a 4 node cluster instead of a 5?
wenyihu6
left a comment
There was a problem hiding this comment.
Reviewable status:
wenyihu6
left a comment
There was a problem hiding this comment.
Reviewable status:
andyyang890
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/tests/cdc.go line 1291 at r1 (raw file):
Previously, wenyihu6 (Wenyi Hu) wrote…
Out of curiosity, any reasons you changed it to a 4 node cluster instead of a 5?
Ah I made this change because in the version of the test where I don't split the ranges, it seems like usually only one node gets the aggregator so I wanted to make it more likely we'd restart that node sooner. Also I believe the default range replication factor is 3 so that's why it's 4 in total (1 node that shouldn't have replicas + 3 with replicas that we're restarting).
|
TFTRs! bors r=rharding6373,wenyihu6 |
|
bors retry |
This patch expands the
cdc/initial-scan-rolling-restarttest to alsotest normal checkpoints (in addition to shutdown checkpoints). It also
updates the test to work on GCE so that it can run during nightly CI.
Informs #123371
Release note: None