Skip to content

drtprod: add datadog-agent setup for workload-chaos#123764

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
itsbilal:drtprod-datadog
May 8, 2024
Merged

drtprod: add datadog-agent setup for workload-chaos#123764
craig[bot] merged 1 commit intocockroachdb:masterfrom
itsbilal:drtprod-datadog

Conversation

@itsbilal
Copy link
Copy Markdown
Contributor

@itsbilal itsbilal commented May 7, 2024

This change updates the drtprod script to add the workload-choas datadog-agent setup commands and config files.

Epic: none

Release note: None

@itsbilal itsbilal requested review from dt and sudomateo May 7, 2024 18:21
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@sudomateo sudomateo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good just blocking merge until we discuss the custom metrics.

@itsbilal itsbilal force-pushed the drtprod-datadog branch from 29ed2d9 to 3d98124 Compare May 8, 2024 19:22
This change updates the drtprod script to add the workload-choas
datadog-agent setup commands and config files.

Epic: none

Release note: None
@itsbilal itsbilal force-pushed the drtprod-datadog branch from 3d98124 to 3c480ac Compare May 8, 2024 20:17
@itsbilal
Copy link
Copy Markdown
Contributor Author

itsbilal commented May 8, 2024

TFTR!

Had to replace the regex with tpcc_* and kv_* because the workload prefix was getting trimmed by the raw_metric_prefix attribute. But now it works. Will merge after green CI - thanks!

@itsbilal
Copy link
Copy Markdown
Contributor Author

itsbilal commented May 8, 2024

bors r=sudomateo

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 8, 2024

@craig craig bot merged commit ccfb104 into cockroachdb:master May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants