roachtest: move node-kill operation to pkill/pgrep-based kill approach#123517
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 2, 2024
Merged
roachtest: move node-kill operation to pkill/pgrep-based kill approach#123517craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
For some reason, `StopServiceForVirtualCluster` fails with this error on drt clusters: ``` 20:23:41 node_kill.go:51: operation status: killing node 1 with signal 15 20:23:41 cluster.go:2148: stoping virtual cluster 20:23:41 operation_impl.go:128: operation failure cockroachdb#1: no service for virtual cluster "" ``` The debug message has a bug, the virtual cluster is set to "system" but it seems like the service discovery process isn't able to determine the cockroach process based on dns settings in the drt project. This change makes the node-kill operation more dns-agnostic by looking for the cockroach process. Epic: none Release note: None
Member
|
This change is |
renatolabs
approved these changes
May 2, 2024
renatolabs
left a comment
There was a problem hiding this comment.
I forgot DRT skips registration 👍
Contributor
Author
|
TFTR! bors r=renatolabs |
Collaborator
|
Also ran into this earlier with something else, and was about to see how node-kill does it. |
herkolategan
approved these changes
May 2, 2024
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason,
StopServiceForVirtualClusterfails with this error on drt clusters:The debug message has a bug, the virtual cluster is set to "system" but it seems like the service discovery process isn't able to determine the cockroach process based on dns settings in the drt project. This change makes the node-kill operation more dns-agnostic by looking for the cockroach process.
Epic: none
Release note: None