Skip to content

ci: check GHA results in TeamCity#123421

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rail:gha-poll
May 8, 2024
Merged

ci: check GHA results in TeamCity#123421
craig[bot] merged 1 commit intocockroachdb:masterfrom
rail:gha-poll

Conversation

@rail
Copy link
Copy Markdown
Member

@rail rail commented May 1, 2024

Bazel Essential CI is a no-op on master and release-24.1 since the GitHub Actions CI migration completed.

This PR adds a new TeamCity build configuration which polls the required GitHub action results and reflects the overall status in TeamCity.

Fixes: DEVINF-1124
Release note: None

@rail rail added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf A-ci Continuous Integration backport-24.1.x Flags PRs that need to be backported to 24.1. labels May 1, 2024
@rail rail self-assigned this May 1, 2024
@rail rail requested a review from a team as a code owner May 1, 2024 22:15
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented May 1, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rail rail force-pushed the gha-poll branch 5 times, most recently from dbc6bdf to 7831893 Compare May 2, 2024 13:28
Bazel Essential CI is a no-op on master and release-24.1 since the GitHub
Actions CI migration completed.

This PR adds a new TeamCity build configuration which polls the required
GitHub action results and reflects the overall status in TeamCity.

Fixes: DEVINF-1124
Release note: None
@rail rail requested a review from rickystewart May 2, 2024 14:03
@rail
Copy link
Copy Markdown
Member Author

rail commented May 2, 2024

I added a new TC configuration and added it to the MPB deps.
Examples https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Ci_Tests_CheckGhaResults?branch=&mode=builds

statuses[c] = nil
}

client := github.NewClient(nil)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unauthenticated, right? We'll hit rate limits even more quickly than usual. Maybe it doesn't make a difference if we do few enough requests.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I can easily add auth if we want. Actually, it was there in the initial version. :)

@rail
Copy link
Copy Markdown
Member Author

rail commented May 8, 2024

bors r=rickystewart

@rail rail closed this May 8, 2024
@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 8, 2024

Already running a review

@rail rail reopened this May 8, 2024
@rail
Copy link
Copy Markdown
Member Author

rail commented May 8, 2024

bors r=rickystewart

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 8, 2024

@craig craig bot merged commit ccfb104 into cockroachdb:master May 8, 2024
@rail rail deleted the gha-poll branch May 8, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Continuous Integration backport-24.1.x Flags PRs that need to be backported to 24.1. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants