sql: add cluster setting to change session defaults for IE#122855
sql: add cluster setting to change session defaults for IE#122855craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit adds an undocumented cluster setting `sql.internal_executor.session_overrides` that allows specifying comma-separated list of 'variable=value' pairs that will override the corresponding session variables for all InternalExecutors. This can provide an escape hatch in case we find a bug that can be disabled via a session variable. Release note: None
|
This change is |
michae2
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @mgartner and @yuzefovich)
pkg/sql/internal.go line 877 at r1 (raw file):
var ieMultiOverride = settings.RegisterStringSetting( settings.ApplicationLevel,
Which roles can set this setting?
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/sql/internal.go line 877 at r1 (raw file):
Previously, michae2 (Michael Erickson) wrote…
Which roles can set this setting?
Good question - everyone how can modify other cluster settings, so those with MODIFYCLUSTERSETTING privilege. This seems reasonable to me - the setting is not marked as public and there is no release note, so it'll remain undocumented.
michae2
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:
pkg/sql/opt/exec/execbuilder/testdata/execute_internally_builtin line 97 at r1 (raw file):
query T SELECT crdb_internal.execute_internally('SHOW optimizer_use_histograms;', false);
Nice pair of features you've created here! 🙂
|
Fingers crossed lol TFTR! bors r+ |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 66a4ea9 to blathers/backport-release-23.2-122855: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This commit adds an undocumented cluster setting
sql.internal_executor.session_overridesthat allows specifying comma-separated list of 'variable=value' pairs that will override the corresponding session variables for all InternalExecutors. This can provide an escape hatch in case we find a bug that can be disabled via a session variable.Fixes: #122542.
Release note: None