spanconfigreconcilerccl: use txn descriptor ID generation for test#122539
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 19, 2024
Merged
spanconfigreconcilerccl: use txn descriptor ID generation for test#122539craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
fqazi
approved these changes
Apr 17, 2024
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
83af06b to
68d3fdc
Compare
…or test This PR updates the spanconfigreconciler data driven test to use transactional descriptor ID generation (cockroachdb#85444) to generate deterministic descriptor IDs. This will help avoid test flakes around changing descriptor IDs due to transaction retries etc. Epic: none Fixes: cockroachdb#122343 Release note: None
68d3fdc to
b1501c1
Compare
Collaborator
Author
|
TFTR! bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the spanconfigreconciler data driven test to use transactional descriptor ID generation
(#69226) to generate deterministic descriptor IDs. This will help avoid test flakes around changing descriptor IDs due to transaction retries etc.
Epic: none
Fixes: #122343
Release note: None