cli: conditionally allow version skipping#121952
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 9, 2024
Merged
cli: conditionally allow version skipping#121952craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Currently the code allows upgrading from TWO previous releases (23.1 and 23.2); however, for now we only want to allow skipping a version experimentally. This commit changes the cli code to set the minimum supported version to `PreviousRelease` by default, or to `MinSupported` when a special env var is used. Epic: none Release note: None
24d13c3 to
94ffde5
Compare
Member
Author
|
I took over #121011, I only made a couple of minor test fixes on top of that. |
celiala
approved these changes
Apr 8, 2024
Collaborator
celiala
left a comment
There was a problem hiding this comment.
Thank you for taking this over the line 💟 🙏
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andyyang890, @msbutler, and @nkodali)
Member
Author
|
TFTR! bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the code allows upgrading from TWO previous releases (23.1 and 23.2); however, for now we only want to allow skipping a version experimentally.
This commit changes the cli code to set the minimum supported version to
PreviousReleaseby default, or toMinSupportedwhen a special env var is used.Epic: none
Release note: None